Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for a corner case met in DC0 #701

Closed
wants to merge 2 commits into from

Conversation

keskitalo
Copy link
Member

No description provided.

@keskitalo
Copy link
Member Author

@tskisner Can you add a fix for this failing unit test?

@tskisner tskisner marked this pull request as ready for review October 5, 2023 05:16
@tskisner
Copy link
Member

tskisner commented Oct 8, 2023

This pull request has greatly expanded from its original scope, and it now also includes fixes for the pointing matrix weights. The unit tests have been expanded to include plots for the detector response across multiple HWP and fixed sky Stokes components. I'll rebase to clean up the commit log before merging, but I believe everything is ready @keskitalo . The documentation of the pointing weights is now added to the toast3_docs branch where the documentation overhaul is ongoing. Attached is PDF of that notebook, which includes panel plots from the new unit tests.

pointing_weights.pdf

src/toast/_libtoast/ops_stokes_weights.cpp Outdated Show resolved Hide resolved
src/toast/_libtoast/ops_pixels_healpix.cpp Outdated Show resolved Hide resolved
src/toast/_libtoast/ops_pixels_healpix.cpp Outdated Show resolved Hide resolved
@tskisner
Copy link
Member

This work was merged in #702. Closing this.

@tskisner tskisner closed this Oct 10, 2023
@tskisner tskisner deleted the fix_healpix_corner_case branch October 10, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants