Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix git checkout toast3 on Windows #719

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix git checkout toast3 on Windows #719

merged 1 commit into from
Dec 11, 2023

Conversation

ickc
Copy link
Contributor

@ickc ickc commented Dec 6, 2023

Currently,

error: invalid path 'src/toast/aux/benchmarks/stats.json'

error: invalid path 'src/toast/aux/weather/LMT.h5'

error: invalid path 'src/toast/aux/weather/atacama.h5'

error: invalid path 'src/toast/aux/weather/convert.py'

error: invalid path 'src/toast/aux/weather/south_pole.h5'

Because AUX is reserved in Windows.

This PR propose replacing aux by _aux using the following code:

FROM=aux
TO=_aux
sed -i "s/$FROM/$TO/" src/toast/CMakeLists.txt
find src/toast -name '*.py' -exec sed -i "s/\"$FROM\"/\"$TO\"/" {} +
git mv "./src/toast/$FROM" "./src/toast/$TO"

Currently,

```log
error: invalid path 'src/toast/aux/benchmarks/stats.json'

error: invalid path 'src/toast/aux/weather/LMT.h5'

error: invalid path 'src/toast/aux/weather/atacama.h5'

error: invalid path 'src/toast/aux/weather/convert.py'

error: invalid path 'src/toast/aux/weather/south_pole.h5'
```

Because AUX is reserved in Windows.

This PR propose replacing aux by _aux using the following code:

```bash
FROM=aux
TO=_aux
sed -i "s/$FROM/$TO/" src/toast/CMakeLists.txt
find src/toast -name '*.py' -exec sed -i "s/\"$FROM\"/\"$TO\"/" {} +
git mv "./src/toast/$FROM" "./src/toast/$TO"
```
@ickc ickc marked this pull request as ready for review December 6, 2023 20:11
@tskisner
Copy link
Member

Thanks @ickc , looks good.

@tskisner tskisner merged commit 43243b4 into hpc4cmb:toast3 Dec 11, 2023
6 checks passed
@ickc ickc deleted the toast3 branch December 11, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants