Implement a mapmaking template for HWP synchronous signal #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement truncated Fourier series technique based on C++ code developed for real-time filtering in kst in 2009. - Add unit tests for low-level math functions and a synthetic scan strategy without atmosphere. - Format source with latest version of black (24.1.1)
…P rate for more realism.
|
An example of one of the plots generated by unit tests, showing the removal of HWPSS as part of the mapmaking: |
keskitalo
approved these changes
Feb 6, 2024
tskisner
added a commit
that referenced
this pull request
Mar 13, 2024
This restores the HWP Stokes response to the model before #736. The changes in that PR were based on observations of a source with known polarization, but resulted in breakage of common-sense tests with discrete detector / HWP orientations. Those polarized source results should be revisited.
tskisner
added a commit
that referenced
this pull request
Mar 13, 2024
This restores the HWP Stokes response to the model before #736. The changes in that PR were based on observations of a source with known polarization, but resulted in breakage of common-sense tests with discrete detector / HWP orientations. Those polarized source results should be revisited.
tskisner
added a commit
that referenced
this pull request
Mar 18, 2024
* Restore HWP Stokes model changes This restores the HWP Stokes response to the model before #736. The changes in that PR were based on observations of a source with known polarization, but resulted in breakage of common-sense tests with discrete detector / HWP orientations. Those polarized source results should be revisited. * Fix detection of test failures * Base groundfilter test criteria on simulated noise level * Fix import. Fix absolute tolerance in baseline comparison. * Fix absolute imports and missing import from obsmat.py * Bump requirements to pshmem 1.0.5, which has fix for macos. * Try to increase the shell limit on number of open files when running tests on macos. * More attempts to increase open file limit on macos * More attempts to increase open file limit on macos again * Bump pshmem requirements. * Speed up some unit tests. Fixes to non-default stokes weights kernels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement truncated Fourier series technique based on C++ code developed for real-time filtering in kst in 2009.
Add unit tests for low-level math functions and a synthetic scan strategy without atmosphere.
Format source with latest version of black (24.1.1)