[tensor] redistribute among different process groups #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1SAA
reviewed
Jul 11, 2022
| if pg is not None and pg != self.get_process_group(): | ||
| print('here _redistribute') | ||
| # if the pg is not equal, convert the current tensor to replicated | ||
| self._redistribute(ReplicaSpec()) |
There was a problem hiding this comment.
I think the updated operand, redistribute, always used for non-model data in training.
It natrual that we need to keep redistribute as an autograd operand.
But here, _redistribute is not capable being used as an autograd operand.
There was a problem hiding this comment.
I see. I will discuss with you offline.
I hope the ColoTensor can be used independently, we don't need to assume it's only used for training.
YuliangLiu0306
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.