[FAW] parallel FreqAwareEmbedding #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps/cacheembedding
…ps/cacheembedding
zxgx
approved these changes
Aug 10, 2022
zxgx
reviewed
Aug 10, 2022
| per_sample_weights, self.include_last_offset, self.padding_idx) | ||
|
|
||
| if shape_hook is not None: | ||
| output_shard = shape_hook(output_shard) |
There was a problem hiding this comment.
the shape hook might introduce some tensor view&squeeze operations.
I suppose we should be aware of that when using ColoParameter.
There was a problem hiding this comment.
OK, can you update it in another PR? I copy this line from yours code.
There was a problem hiding this comment.
ColoTensor's spec had troubles with view operations before.
Does it support ColoTensor.view and ColoTensor.transpose now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.