Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FAW] refactor reorder() for CachedParamMgr #1514

Merged
merged 4 commits into from
Aug 29, 2022
Merged

[FAW] refactor reorder() for CachedParamMgr #1514

merged 4 commits into from
Aug 29, 2022

Conversation

feifeibear
Copy link
Contributor

@feifeibear feifeibear commented Aug 29, 2022 •
edited
Loading

LFU eviction supports reordering with ids_freq_mapping.
LFU does not need to reorder the CPU weight idx.

CsRic
CsRic approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@CsRic CsRic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

colossalai/nn/parallel/layers/cache_embedding/cache_mgr.py Outdated Show resolved Hide resolved
@feifeibear feifeibear merged commit af5438c into hpcaitech:main Aug 29, 2022
@feifeibear feifeibear deleted the faw/lfu4 branch August 29, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CsRic CsRic CsRic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feifeibear @CsRic