Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] add LoRA support #2821

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[example] add LoRA support #2821

merged 2 commits into from
Feb 20, 2023

Conversation

haofanwang
Copy link
Contributor

This PR is motivated by train_text_to_image_lora.py. ColossalAI framework can further optimize the training.

@github-actions
Copy link
Contributor

Your pre-commit check failed, follow the steps to run pre-commit on your file for code style consistency.

  1. install pre-commit via "pip install pre-commit"
  2. install pre-commit hooks via "pre-commit install"
  3. run pre-commit on file with format error via "pre-commit run --files path" by replacing "path" with the actual file path
  4. commit and push to your branch

View your job at https://github.com/hpcaitech/ColossalAI/actions/runs/4215016352.
Read our "CONTRIBUTING.md" for more reference to the code style.

Copy link
Contributor

@Fazziekey Fazziekey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, LoRA is an amazing tech to finetune model

@Fazziekey
Copy link
Contributor

@haofanwang can you run pip install pre-commit && pre-commit install to fix your code style and pass our ci? Here is the contributed guide: https://github.com/hpcaitech/ColossalAI/blob/main/CONTRIBUTING.md

@haofanwang
Copy link
Contributor Author

@Fazziekey Done.

@Fazziekey Fazziekey merged commit 47ecb22 into hpcaitech:main Feb 20, 2023
@Fazziekey
Copy link
Contributor

@haofanwang Thanks a lot for your Pull request, it is really amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants