Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix post-commit workflow #3238

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[BUG] Fix post-commit workflow #3238

merged 1 commit into from
Mar 27, 2023

Conversation

nijkah
Copy link
Contributor

@nijkah nijkah commented Mar 24, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Closes #3237

📝 What does this PR do?

The 'outputs' condition can be used only if the step or job has 'outputs'.
So the current post-commit workflow doesn't work and linting hasn't been done in a while.
It should be changed to use 'outcome'.

In addition to this, I also ran lint on .github/* because github-action-bot is not allowed to edit workflow files.
https://github.com/nijkah/ColossalAI/actions/runs/4510424710/jobs/7941438856#step:12:81

My test action link is nijkah#7

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@nijkah nijkah mentioned this pull request Mar 24, 2023
10 tasks
@FrankLeeeee
Copy link
Contributor

Awesome, thanks @nijkah !

@FrankLeeeee FrankLeeeee merged commit 1653063 into hpcaitech:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Post-commit workflow does not work!
2 participants