[gemini] add GeminiMemoryManger #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feifeibear
reviewed
Apr 22, 2022
feifeibear
reviewed
Apr 22, 2022
colossalai/gemini/tensorful_state.py
Outdated
| else: | ||
| # when from_state is FREE, the tensor is new to manager | ||
| # we should add its memory | ||
| manager.total_mem[device_type] += size |
There was a problem hiding this comment.
How do you know the tensor is new to manager.
There was a problem hiding this comment.
Now, every payload holds its own memory.
feifeibear
reviewed
Apr 22, 2022
colossalai/gemini/tensorful_state.py
Outdated
| del self._payload | ||
|
|
||
| # record new payload | ||
| StatefulTensor.trans_state_update(tensor, TensorState.FREE, self.state) |
There was a problem hiding this comment.
We must call this function when the payload is newed or deleted.
Therefore trans_state_update is coupled with reset_payload and move_to.
Here are some negative effects.
First, it is not applicable to the other place. Because you have to keep in mind that the tensor is exactly allocated or deleted.
Or some others should not use the function. It is dangerous and will mess up your plan.
There was a problem hiding this comment.
I'm gonna change them to private functions.
* refactor StatefulTensor, tensor utilities * add unitest for GeminiMemoryManager
|
My unitest result in torch-1.10 |
ver217
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor StatefulTensor, tensor utilities
add unitest for GeminiMemoryManager