Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package fixes #43

Merged
merged 24 commits into from
Jan 13, 2022
Merged

Package fixes #43

merged 24 commits into from
Jan 13, 2022

Conversation

benrobby
Copy link
Contributor

@benrobby benrobby commented Jan 12, 2022

  • adds github action to run tests on PR
  • adds two parameters to specify custom output files
  • restructures packages (again) because I noticed errors when trying to use this in our library
  • fixes pypi tests, they were not properly testing the installation from testpypi but simply using the local files

@benrobby benrobby marked this pull request as draft January 12, 2022 23:10
@benrobby benrobby marked this pull request as ready for review January 13, 2022 00:24
Copy link
Contributor

@ChristopherSchmidt89 ChristopherSchmidt89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comments regarding new input parameters. Apart from that it looks good to me

manm_cs/__main__.py Outdated Show resolved Hide resolved
manm_cs/__main__.py Outdated Show resolved Hide resolved
manm_cs/__main__.py Outdated Show resolved Hide resolved
manm_cs/__main__.py Outdated Show resolved Hide resolved
@benrobby
Copy link
Contributor Author

I addressed all of the feedback so I hope it's okay if I merge it straight away

@benrobby benrobby merged commit 0422487 into master Jan 13, 2022
@benrobby benrobby deleted the package-fixes branch January 13, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants