Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/offline mode improvements #593

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Conversation

johannesvedder
Copy link
Contributor

Improves the reliability of the offline mode.

How to Test this PR

  1. Launch a development database and create a study with the Designer.
  2. Join a study by using the app in debug mode on a mobile device and skip to the first day.
  3. Fill out the observation of the first day, click "next day", and thereafter close (force stop/kill) the app.
  4. Shutdown the database.
  5. Open the app again. The app should now perform in offline mode. The app state should not have changed.
  6. Fill out the observation of the second day. Force the app to stop again.
  7. Launch the database again.
  8. Start the app. The app state should not have changed and show a tick for the filled out observation of step 6.
  9. Validate the entries by logging into the Supabase backend and check if the subject_progress table contains the two entries of this test.
  10. If any entries are missing or the behavior of the app was different than described here, the test has failed.

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file app core labels Mar 15, 2024
@johannesvedder johannesvedder added this to the Release(2024-03) milestone Mar 15, 2024
@johannesvedder johannesvedder mentioned this pull request Mar 15, 2024
5 tasks
Copy link

github-actions bot commented Mar 15, 2024

Visit the preview URL for this PR (updated for commit 014801f):

(expires Sat, 23 Mar 2024 16:34:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2149dad49ed83535217e50d5c18c0c8c90da629b

Copy link

github-actions bot commented Mar 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@hig-dev hig-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test instructions. It worked.

@johannesvedder johannesvedder merged commit 69cf19d into dev Mar 22, 2024
6 checks passed
@johannesvedder johannesvedder deleted the fix/offline-mode-improvements branch March 22, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app core dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants