Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive morph onAbandon connection is not cleared after dragging interactive out of editor #710

Closed
frcroth opened this issue May 17, 2021 · 6 comments
Closed

Interactive morph onAbandon connection is not cleared after dragging interactive out of editor #710

frcroth opened this issue May 17, 2021 · 6 comments
Labels
bug Something isn't working high ⭐ ⭐ ⭐ This has a high priority and should be done ASAP
Milestone
Final Sprint

Comments

@frcroth
Copy link
Contributor

frcroth commented May 17, 2021

Which does not allow bundling
@frcroth frcroth added bug Something isn't working high ⭐ ⭐ ⭐ This has a high priority and should be done ASAP labels May 17, 2021
@frcroth frcroth added this to the Final Sprint milestone May 17, 2021
@linusha
Copy link
Contributor

linusha commented May 17, 2021 •
edited
Loading

Just to make sure - you are on this branch? Because otherwise that is not surprising, as dragging morphs out of the interactive is not currently supported on dev.

@frcroth
Copy link
Contributor Author

frcroth commented May 17, 2021 via email

@Paula-Kli
Copy link
Contributor

no it is not about dragging morphs out of the interactive.. it is about morphs which are still in the interactive just grabbing the interactive out of the editor

@linusha
Copy link
Contributor

linusha commented May 17, 2021

If you know how to reproduce it let's check again after #697 is merged, ok? It might be #698, which was not only the case for the creation of connections, but also for how they were disconnected. This should be fixed in the same PR I'd hope. 🙂

@frcroth frcroth changed the title Interactive morph onAbandon connection is not cleared after dragging morph out of interactive Interactive morph onAbandon connection is not cleared after removing morph out of interactive May 17, 2021
@frcroth frcroth changed the title Interactive morph onAbandon connection is not cleared after removing morph out of interactive Interactive morph onAbandon connection is not cleared after dragging interactive out of editor May 17, 2021
@Paula-Kli
Copy link
Contributor

thinking about my interaction again @frcroth might have been right in the first place... I think we need to remove from the now created scrollytelling all connections and afterwards I can check again... there were strange things happening I am not sure about it anymore... sorry

@frcroth frcroth mentioned this issue May 18, 2021
Merged
4 tasks
@linusha
Copy link
Contributor

linusha commented May 19, 2021

This should be solved with #697. Please reopen again if that is not the case.

@linusha linusha closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high ⭐ ⭐ ⭐ This has a high priority and should be done ASAP
Projects
None yet
Milestone
Final Sprint
Development

No branches or pull requests
3 participants
@frcroth @linusha @Paula-Kli