create GithubActions workflow for tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create preLoading.st * Add files via upload * Rename linter.ston to .linter.ston * Add linter class and methods * Delete packages/MorphicAPIExplorer-Tests.package/CRLinter.class directory * Add linter class and methods, now renamed * second half of linter methods * Update .linter.ston * Update crCorePackage.st * Rename crCorePackage.st to mexCorePackage.st * Update and rename crTestsPackage.st to mexTestsPackage.st * Update README.md * Update methodProperties.json * Update properties.json * update .smalltalk.ston to exclude Linter class * Update setUp.st * Update .smalltalk.ston * Update .smalltalk.ston
Closed
Zyranix
changed the title
|
Please comment for each dont/brokenTest why this needed to be categorized as such. |
PashPaul
approved these changes
Jun 19, 2021
|
Now, the tests for ver 5.1 and 5.2 are failing. Could you have a look at your changes and try to find out the unsupported method? |
|
|
Zyranix
commented
Jun 20, 2021
...Explorer-Tests.package/MEXLinter.class/instance/brokenVariableIsOnlyAssignedALiteralValue.st
Show resolved
Hide resolved
Zyranix
commented
Jun 20, 2021
...IExplorer-Tests.package/MEXLinter.class/instance/brokenTestUsesDoInsteadOfCollectOrSelect.st
Outdated
Show resolved
Hide resolved
Zyranix
commented
Jun 20, 2021
...ckage/MEXLinter.class/instance/dontTestAddDependantMethodsLessOrEqualThanRemoveDependents.st
Outdated
Show resolved
Hide resolved
|
Also, dont-Tests are things we still want to log (but not let the CI job fail). In order to do this, you have to add the linting rule to |
…hpi-swa-teaching/MorphicAPIExplorer.git into feature-switchCIToGithubActions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.