-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
432/show vSphere path in VMs show #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -7,7 +7,13 @@ | |||
end %> | |||
|
|||
<div class="container mb-3 pl-0 pr-0 clearfix"> | |||
<h1 class="mb-0"><%= @vm.name unless @vm.nil? %></h1> | |||
<ol class="breadcrumb" aria-label="The Virtual Machines full path"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the positioning on the page 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes overall!
@@ -1,5 +1,9 @@ | |||
# frozen_string_literal: true | |||
|
|||
# Part of Ruby stdlib, used for IP regexes | |||
# https://www.rubydoc.info/stdlib/resolv/Resolv | |||
require 'resolv' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of the Ruby stdlib 👍
Closes #432, fixes #438 and also closes #477