432/show vSphere path in VMs show #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthes
requested review from
bdaase,
BraunTom,
krichly,
rteusner and
chrisma
bdaase
approved these changes
Mar 16, 2019
| @@ -7,7 +7,13 @@ | |||
| end %> | |||
|
|
|||
| <div class="container mb-3 pl-0 pr-0 clearfix"> | |||
| <h1 class="mb-0"><%= @vm.name unless @vm.nil? %></h1> | |||
| <ol class="breadcrumb" aria-label="The Virtual Machines full path"> | |||
There was a problem hiding this comment.
I like the positioning on the page 👍
chrisma
requested changes
Mar 18, 2019
| @@ -1,5 +1,9 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Part of Ruby stdlib, used for IP regexes | |||
| # https://www.rubydoc.info/stdlib/resolv/Resolv | |||
| require 'resolv' | |||
There was a problem hiding this comment.
Nice use of the Ruby stdlib 👍
chrisma
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432, fixes #438 and also closes #477