Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize styling #498

Merged
merged 72 commits into from
Mar 27, 2019
Merged

Standardize styling #498

merged 72 commits into from
Mar 27, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Mar 22, 2019 •
edited
Loading

  • Remove as much custom CSS as possible
  • Rely on bootstrap classes and layouts
  • Remove as much custom JS as possible
  • Remove empty coffee and SCSS files
  • Restructure Gemfile

@chrisma
Fix(Hosts index): Move to datatables usage
0fa0413
@chrisma
Chore(Application.scss): Whitespace
b06ffbe
@chrisma
Fix(Projects index): Use datatables
e66b271
@chrisma
Fix(Servers index): Use datatables
cc7b3a8
@chrisma
Fix(Users index: Use datatables. Cleanup.
ae81656 
Show role instead of disabled buttons when no change right exist.
@chrisma
Fix(Users index): Display date nicely.
39fc489
@chrisma
Fix(OS index): Use datatables
0ab8ea0
@chrisma
Fix(Requests index): Use datatables
94dd42b
@chrisma
Fix(Users index): handle nil in current_sign_in_at
50bfa6f
@chrisma
Fix(Requests index): Top navigation buttons
152c5ef
@chrisma
Fix(Requests index): Use datatables. Cleanup.
0a8c43d
@chrisma
Fix(projects table): Readd table partial.
95782df 
It's used in Users#show
@chrisma
Fix(Users index): Readd HTML ids used for testing
7603e38
@chrisma
Fix(Projects index): USe of parenthesis
ed30074
@chrisma
Fix(VMs index): Use datatables.
2a12a17
@chrisma
Fix(Index): Tooltips for status
2fc242e
@chrisma
Fix(VMs index): refactor buttons. Add tooltips.
7925476
@chrisma
Fix(VMs index): Handle searching for descriptions
f6cc887
@chrisma
Chore(CSS): Remove unused class
128e9cc
@chrisma
Chore(CSS): Remove unused 'table-bar' class
b4f5f87
@chrisma
Chore(Request teamplate CSS): Remove classes
2d44b86
@chrisma
Fix(Requests show): Remove CSS classes
333c377
@chrisma
Fix(projects show): Remove CSS classes.
e20fa82
@chrisma
Chore(CSS): Remove empty SCSS files
ef5638c
@chrisma chrisma self-assigned this Mar 22, 2019
@chrisma chrisma added the WIP work is still in progess for this PR label Mar 22, 2019
@chrisma chrisma added Review Required WIP work is still in progess for this PR and removed WIP work is still in progess for this PR Review Required labels Mar 25, 2019
bdaase
bdaase reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2019-03-27 09-04-57
Is it intended, that the user select is that small?

@chrisma
Copy link
Contributor Author

chrisma commented Mar 27, 2019 •
edited
Loading

Is it intended, that the user select is that small?

I've added the correct Bootstrap class, so that the field has the same width as the other elements now, good catch. The font size is the default.

bdaase
bdaase approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bdaase bdaase merged commit c57751d into dev Mar 27, 2019
@bdaase bdaase deleted the standardize_styling branch March 27, 2019 09:51
@bdaase bdaase mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdaase bdaase bdaase approved these changes

Assignees

@chrisma chrisma

Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisma @bdaase