Standardize styling #498

chrisma · 2019-03-22T21:23:45Z

Remove as much custom CSS as possible
Rely on bootstrap classes and layouts
Remove as much custom JS as possible
Remove empty coffee and SCSS files
Restructure Gemfile

Show role instead of disabled buttons when no change right exist.

It's used in Users#show

bdaase

Is it intended, that the user select is that small?

…nto standardize_styling

chrisma · 2019-03-27T08:54:02Z

Is it intended, that the user select is that small?

I've added the correct Bootstrap class, so that the field has the same width as the other elements now, good catch. The font size is the default.

bdaase

👍

chrisma added 24 commits March 22, 2019 11:36

Fix(Hosts index): Move to datatables usage

0fa0413

Chore(Application.scss): Whitespace

b06ffbe

Fix(Projects index): Use datatables

e66b271

Fix(Servers index): Use datatables

cc7b3a8

Fix(Users index: Use datatables. Cleanup.

ae81656

Show role instead of disabled buttons when no change right exist.

Fix(Users index): Display date nicely.

39fc489

Fix(OS index): Use datatables

0ab8ea0

Fix(Requests index): Use datatables

94dd42b

Fix(Users index): handle nil in current_sign_in_at

50bfa6f

Fix(Requests index): Top navigation buttons

152c5ef

Fix(Requests index): Use datatables. Cleanup.

0a8c43d

Fix(projects table): Readd table partial.

95782df

It's used in Users#show

Fix(Users index): Readd HTML ids used for testing

7603e38

Fix(Projects index): USe of parenthesis

ed30074

Fix(VMs index): Use datatables.

2a12a17

Fix(Index): Tooltips for status

2fc242e

Fix(VMs index): refactor buttons. Add tooltips.

7925476

Fix(VMs index): Handle searching for descriptions

f6cc887

Chore(CSS): Remove unused class

128e9cc

Chore(CSS): Remove unused 'table-bar' class

b4f5f87

Chore(Request teamplate CSS): Remove classes

2d44b86

Fix(Requests show): Remove CSS classes

333c377

Fix(projects show): Remove CSS classes.

e20fa82

Chore(CSS): Remove empty SCSS files

ef5638c

chrisma self-assigned this Mar 22, 2019

chrisma added the WIP work is still in progess for this PR label Mar 22, 2019

chrisma added 4 commits March 22, 2019 22:27

Chore(JS): Remove empty coffee files

3b218c1

Fix(dashboard): Remove markup

2aa1227

Fix(dashboard): Don't show datatables controls

dd8da9d

Fix(dashboard): Spacing between tables

41de964

chrisma added 12 commits March 24, 2019 16:33

Fix(CSS): Organize CSS styles

f3e91af

Fix(CSS): .unread -> .bg-primary-light

5995b41

Fix(dashboard): Remove custom styling

c58fc6f

Fix(CSS): custom datatables styling

78e3fe9

Fix(CSS): Add comment for datatables custom CSS

d7c6133

Fix(Project form): Bootstrap layout

efb4825

Fix(request template views): Remove back buttons, less HTML

c5927d8

Fix(Server form): Style 'Add software' button

08e3fbe

Fix(Server new): Remove back button

d2970eb

Merge branch 'dev' into standardize_styling

a40303a

Merge branch 'dev' into standardize_styling

3d8f62f

Merge branch 'dev' into standardize_styling

55e7d94

chrisma added Review Required WIP work is still in progess for this PR and removed WIP work is still in progess for this PR Review Required labels Mar 25, 2019

chrisma added this to In progress in Project Board via automation Mar 26, 2019

chrisma moved this from In progress to Needs review in Project Board Mar 26, 2019

bdaase reviewed Mar 27, 2019

View reviewed changes

chrisma added 3 commits March 27, 2019 09:48

Merge branch 'dev' into standardize_styling

6822396

Fix(Projects form): Bootstrap class for resp. users field

73a45a7

Merge branch 'standardize_styling' of github.com:hpi-swt2/vm-portal i…

207bc25

…nto standardize_styling

bdaase approved these changes Mar 27, 2019

View reviewed changes

bdaase merged commit c57751d into dev Mar 27, 2019

Project Board automation moved this from Needs review to Done Mar 27, 2019

bdaase deleted the standardize_styling branch March 27, 2019 09:51

bdaase mentioned this pull request Mar 28, 2019

User selection looks broken #531

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standardize styling #498

Standardize styling #498

chrisma commented Mar 22, 2019 •

edited

Loading

bdaase left a comment

chrisma commented Mar 27, 2019 •

edited

Loading

bdaase left a comment

Standardize styling #498

Standardize styling #498

Conversation

chrisma commented Mar 22, 2019 • edited Loading

bdaase left a comment

Choose a reason for hiding this comment

chrisma commented Mar 27, 2019 • edited Loading

bdaase left a comment

Choose a reason for hiding this comment

chrisma commented Mar 22, 2019 •

edited

Loading

chrisma commented Mar 27, 2019 •

edited

Loading