Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize styling #498

Merged
merged 72 commits into from
Mar 27, 2019
Merged

Standardize styling #498

merged 72 commits into from
Mar 27, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Mar 22, 2019

  • Remove as much custom CSS as possible
  • Rely on bootstrap classes and layouts
  • Remove as much custom JS as possible
  • Remove empty coffee and SCSS files
  • Restructure Gemfile

@chrisma chrisma self-assigned this Mar 22, 2019
@chrisma chrisma added the WIP work is still in progess for this PR label Mar 22, 2019
@chrisma chrisma added Review Required WIP work is still in progess for this PR and removed WIP work is still in progess for this PR Review Required labels Mar 25, 2019
Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2019-03-27 09-04-57
Is it intended, that the user select is that small?

@chrisma
Copy link
Contributor Author

chrisma commented Mar 27, 2019

Is it intended, that the user select is that small?

I've added the correct Bootstrap class, so that the field has the same width as the other elements now, good catch. The font size is the default.

Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bdaase bdaase merged commit c57751d into dev Mar 27, 2019
@bdaase bdaase deleted the standardize_styling branch March 27, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants