Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

488/DeleteProjects #502

Merged
merged 19 commits into from
Mar 27, 2019
Merged

488/DeleteProjects #502

merged 19 commits into from
Mar 27, 2019

Conversation

bdaase
Copy link
Contributor

@bdaase bdaase commented Mar 23, 2019

Fixes #488

@bdaase bdaase added the WIP work is still in progess for this PR label Mar 23, 2019
@bdaase bdaase self-assigned this Mar 23, 2019
chrisma
chrisma requested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@chrisma chrisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

chrisma
chrisma requested changes Mar 25, 2019
View reviewed changes
app/controllers/projects_controller.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
chrisma
chrisma requested changes Mar 25, 2019
View reviewed changes
app/views/projects/_list.html.erb Outdated Show resolved Hide resolved
@bdaase bdaase requested a review from chrisma March 25, 2019 17:36
@bdaase bdaase added Review Required and removed WIP work is still in progess for this PR labels Mar 25, 2019
chrisma
chrisma previously approved these changes Mar 26, 2019
View reviewed changes
@chrisma
Copy link
Contributor

chrisma commented Mar 26, 2019 •
edited
Loading

Ended up refactoring Project#show somewhat ¯\(ツ)/¯
Check it out

@chrisma chrisma dismissed their stale review March 26, 2019 10:00

Stale review

@bdaase
Copy link
Contributor Author

bdaase commented Mar 26, 2019

@chrisma Thanks, the refactoring of the show page is great!
But is the 'Delete-Button' gone now? Or do I miss something?

@chrisma
Copy link
Contributor

chrisma commented Mar 26, 2019 •
edited
Loading

But is the 'Delete-Button' gone now? Or do I miss something?

The delete button is on the Project#show detail page, as deletion of projects is not a common task that needs to be available from the index. See https://github.com/hpi-swt2/vm-portal/pull/502/files#diff-2476f44a5f0802d146b181eeb56e8a12, line 33

image

@bdaase
Copy link
Contributor Author

bdaase commented Mar 27, 2019 •
edited
Loading

But is the 'Delete-Button' gone now? Or do I miss something?

The delete button is on the Project#show detail page, as deletion of projects is not a common task that needs to be available from the index. See https://github.com/hpi-swt2/vm-portal/pull/502/files#diff-2476f44a5f0802d146b181eeb56e8a12, line 33

image

Perfect, if you approve it now, we can merge 👍

@bdaase bdaase requested a review from chrisma March 27, 2019 07:55
@chrisma chrisma merged commit 516ba12 into dev Mar 27, 2019
@chrisma chrisma deleted the 488/DeletionOfProjects branch March 27, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisma chrisma chrisma approved these changes

Assignees

@bdaase bdaase

Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdaase @chrisma