Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

519/Edit Software of server #521

Merged
merged 16 commits into from
Mar 31, 2019
Merged

519/Edit Software of server #521

merged 16 commits into from
Mar 31, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Mar 26, 2019

See: #519

@chrisma chrisma mentioned this pull request Mar 26, 2019
@chrisma chrisma self-assigned this Mar 26, 2019
@bdaase
Copy link
Contributor

bdaase commented Mar 27, 2019

I think we should also give the possibility to either remove software when editing or at least delete the empty fields. Otherwise, they will grow over time without having content.

@chrisma
Copy link
Contributor Author

chrisma commented Mar 27, 2019

I think we should also give the possibility to either remove software when editing or at least delete the empty fields. Otherwise, they will grow over time without having content.

Software can be removed by visiting the Software#edit page and removing the rendered string from the input. You are correct, empty form fields are currently not removed in the controller. I didn' feel like investing any more work into a "feature" that should have been a single text field.

@chrisma
Copy link
Contributor Author

chrisma commented Mar 27, 2019

I fixed it anyways

@LeonMatthes LeonMatthes mentioned this pull request Mar 31, 2019
1 task
@bdaase
Copy link
Contributor

bdaase commented Mar 31, 2019

@chrisma @MrModder I resolved the conflicts so this should be ready to merge now, right?

@chrisma chrisma merged commit a29c3cd into dev Mar 31, 2019
@chrisma chrisma deleted the 519/server_software branch March 31, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants