Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massively speed up tests #539

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Massively speed up tests #539

merged 2 commits into from
Apr 3, 2019

Conversation

chrisma
Copy link
Contributor

@chrisma chrisma commented Apr 3, 2019 •
edited
Loading

Generating a new SSH key for every user employed in tests is expensive

Test run time: 2:30min -> 0:40min

bdaase
bdaase approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@bdaase bdaase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍
Screenshot from 2019-04-03 21-30-31

@chrisma chrisma merged commit abc7d73 into dev Apr 3, 2019
@chrisma chrisma deleted the speedy_tests branch April 3, 2019 20:05
@LeonMatthes
Copy link
Contributor

I LOVE IT! 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdaase bdaase bdaase approved these changes

Assignees
No one assigned
Labels
Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisma @LeonMatthes @bdaase