-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "kitty" instead of "sixels" as default format for WezTerm #149
Conversation
Looks good. Thanks! |
The black background you're seeing is the current workaround for #104. |
Just came across this... Would like to note that the state of kitty graphics on wezterm is still experimental and quite non-compliant with the spec (and the reference implementation)... I think I remember mentioning this on some other issue before. The major issue that would affect chafa is probably wez/wezterm#2084. wez/wezterm#2761 has been open to fix this for months now with no response from Wez. In other words... until Chafa implements support for Kitty image IDs or the issue is fixed, I don't think the kitty format would be usable on Wezterm. I wouldn't suggest the iterm2 format either. See wez/wezterm#3715. |
I see, thanks for bringing it up. It's unclear to me how using explicit image IDs could work around it, though. If there are multiple Chafa invocations from a shell and they all use e.g. image number 1, wouldn't we run into the same issue? Or do you think we could use image IDs specifically (as opposed to numbers) somehow? |
True. Sorry, "Image numbers" (the Anyways, this (Image numbers, not IDs) would have to go with the EDIT: |
Confirmed, it works with |
I guess that'll be best. I've always had it in mind to curate a list of these issues and report them all (recently did that for the iterm2 protocol) but:
but someday soon I'll get to it. |
One could do the same for sixels (there's some very nice detective work in #148). In that case I think the fix is tiny in most cases. The difficult part is getting everyone to agree on something :-) |
Very true! I think highest chances of convincing the developers would be via demo(s) comparing the terminal's current implementation with the proposed implementation. With the rationale behind the proposed implementation. Even with that, it might still be difficult to get some terminal emulators to change their behaviour, especially if they've specified/advertised that behaviour to their users already or there's already too much dependence on the behaviour... It's almost like the case with direct color SGR sequences, except that this case may not have existed for as long. |
No problem. My bad, I should have tested more extensively. Thanks @AnonymouX47 for pointing that tout. |
Thought I should mention that wez/wezterm#3715 has now been fixed... though only in the nightly build for now. |
Great! I think we should stick with sixels until the fixed version becomes widely deployed. |
Following #148.
Tested with
wezterm 20230408-112425-69ae8472
and the support for Kitty protocol seems pretty good from what I tested.The animation from GIF images are much smoother than with the sixels protocol. The transparency is supported for static frames (right), however it displays a black background for GIF (left):