Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add candidate to preview URL #201

Closed
4 tasks
ai opened this issue May 14, 2024 · 2 comments · Fixed by #208
Closed
4 tasks

Add candidate to preview URL #201

ai opened this issue May 14, 2024 · 2 comments · Fixed by #208
Assignees
Labels

Comments

@ai
Copy link
Contributor

ai commented May 14, 2024

We do not keep the current selected candidate in /feeds/add URL.

Let’s add it. It will simplify the two-page logic a lot since we will not have route-less back logic.

  • Add candidate to core/router.ts
  • Add route to web/stores/router.ts
  • Change core/preview.ts to use router
  • Change web client to use links instead of buttons on Add Feed page
@ai ai added the Core JS label May 14, 2024
@github-project-automation github-project-automation bot moved this to Ready to Take in Slow Reader Tasks May 14, 2024
@ilyatitovich
Copy link
Contributor

I want to take it

@ai
Copy link
Contributor Author

ai commented May 15, 2024

Sure!

@ai ai moved this from Ready to Take to In Progress in Slow Reader Tasks May 15, 2024
@ai ai closed this as completed in #208 May 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Wait for Deploy in Slow Reader Tasks May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Wait for Deploy
Development

Successfully merging a pull request may close this issue.

2 participants