Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact/sparse comm #96

Merged
merged 131 commits into from
Nov 22, 2023
Merged

Refact/sparse comm #96

merged 131 commits into from
Nov 22, 2023

Conversation

greole
Copy link
Collaborator

@greole greole commented Oct 31, 2023 •
edited
Loading

This PR builds OGL based on ginkgos sparse_communicator branch which is fairly up to date this should help to build OGL on ginkgo dev in future. Besides that HostMatrix has been refactored substantially:

  • Adds further docstrings to HostMatrix.H
  • Move implementation to HostMatrix.C
  • Add some free functions for filling the matrix to allow unit testing (planned for a separate PR)
  • Removed support for repartitioning, since this should be handled on Ginkgo side at some point. Additionally instead of repartitioning oversubscription seems to be more performant for simple cases. Dropping repartitioning support will allow for reordering on the device, which should give another performance boost.

@greole
base on sparse communicator branch
fd2e5d8
@greole
adapt to new Ginkgo version
c9d2c03
@greole
Use localized_partition
913b79c
@greole
Fixup
53b97c0
@greole
construct sparse communicator
400b861
@greole
reformat
ab0d0e2
@greole
reformat
6ebed5e
@greole
Allow - as separator
214cde7
@greole
Allow - as separator
dfaca26
@greole
switch gko version to include try-run patch
c33c27b
@greole
add a todo fixme notes check
6eca357
@greole
Merge branch 'refact/sparse_comm' of github.com:hpsim/OGL into refact…
6132126 
…/sparse_comm
@greole
add a todo fixme notes check
d82ac3f
@greole
add a todo fixme notes check
27b2bda
@greole
add read_distributed with sparse comm
110310f 
- removed repartitioning for now
- moved sorted validation to python script (not implemented yet)
@greole
use local indices
024acdb
@greole
fixup
a6f341d
@greole
compute send_idxs
7aa7c4c
@greole
reorder header
25e80f7
@greole
move ctr to body
e360350
@greole
remove gko globalIndex
0c96fff
@greole
add stopping criterion
0eef355
@greole
switch gko branch
fa62373
@greole
reformat
7ec2633
@greole
format
235c3c6
@greole
fix typo
41cf412
@greole
Move ctr to .C file
63b1360
@greole
use concrete types for interfaces
ec020eb
@greole
clean-up
3d8572b
@greole
add fs creation
109f6bf
greole and others added 28 commits November 20, 2023 12:35
@greole
fix lib specs
bfc5e98
@greole
source OF
d69701b
@greole
linked sys-openmpi libPsream
2f1d769
@greole
source OF for unitTestBuild
a463dae
@HendriceH
Update CMakeLists.txt
4a10253
@HendriceH
Update CMakeLists.txt
8725113
@HendriceH
Update common.C
8f1ab5d
@greole
build tests for different mpi versions
d28aa40
@greole
add DL libs
dd4c73d
@greole
add cmake format target and format cmake files
3bdae8f
@greole
clean up
8165ebb
@greole
add cmake-format file
b7f23fb
@greole
deactivate unit test for now
e5f09eb
@HendriceH @greole
Update common/common.C
a0f4670 
Co-authored-by: Gregor Olenik <gregor.olenik@web.de>
@HendriceH @greole
Update CMakeLists.txt
1d402e3 
Co-authored-by: Gregor Olenik <gregor.olenik@web.de>
@HendriceH @greole
Update CMakeLists.txt
0db5b8d 
Co-authored-by: Gregor Olenik <gregor.olenik@web.de>
@greole
deactivate unit test for now
de03f24
@HendriceH
Link stdc++fs into OGL
033778c
@greole
add common notation and scotch decomposition
9a0ac1c
@greole
remove unit test dependency
34d8333
@HendriceH
Use CUDA_ARCHITECTURES=native for GPU detection
a92ab41
@greole
Merge pull request #99 from HendriceH/aws_compile
5ad5234 
Adjust OGL to run with ec2 github runner
@greole
Merge branch 'refact/sparse_comm' into fix/non_unique_interface
4c2f65f
@greole
use interface_iterator
95c5db3
@greole
Merge pull request #98 from hpsim/fix/non_unique_interface
3f53286 
Fix/non unique interface
@greole
format
2376f66
@greole
check for TODO DONT MERGE instead of TODO FIXME
c642000
@greole
exclude .github folder
f4d9c41
@greole greole merged commit 029ca1a into dev Nov 22, 2023
11 checks passed
zbinkz
zbinkz reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@zbinkz zbinkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice to see new documentation strings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbinkz zbinkz zbinkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greole @zbinkz @HendriceH