Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate supports_ref_counts #452

Closed
mattip opened this issue Oct 19, 2023 · 2 comments
Closed

Duplicate supports_ref_counts #452

mattip opened this issue Oct 19, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mattip
Copy link
Contributor

mattip commented Oct 19, 2023

A second implementation of the supports_ref_counts function in support.py was added in PR #390, I think this was supposed to be named something related to vectorcall?

hpy/test/support.py

Lines 498 to 505 in f611473

def supports_refcounts(self):
""" Returns True if the underlying Python implementation supports
the vectorcall protocol.
By default, this returns True for Python version 3.8+ on all
implementations.
"""
return sys.version_info >= (3, 8)

@fangerer

@fangerer
Copy link
Contributor

True, that was a mistake. I'll fix it.

@fangerer fangerer self-assigned this Oct 19, 2023
@fangerer fangerer added the bug Something isn't working label Oct 19, 2023
@fangerer fangerer added this to the ABI version 2 milestone Oct 19, 2023
@mattip
Copy link
Contributor Author

mattip commented Nov 30, 2023

Closed by #455

@mattip mattip closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants