-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set encoder bitrate #6
Comments
signal type is called "application" in opus speak, it's an argument to the encoder constructors / initializers. The bitrate &c are encoder flags, currently only DTX is exposed. There's a bunch of them and I'll accept PRs for them (don't forget tests). I don't need them so I'm not going to implement this, but feel free to add whatever you need. See DTX for an example. Cheers! |
I'm renaming this issue to be about bitrate specifically. I want a clear fixable target so the ticket doesn't remain open forever. Feel free to open new tickets as you see fit. |
Fair enough. Btw the API does provide a separate "application" (VoIP/music) and "signal type" (voice/audio). I don't know if they are the same. I guess the former sets the latter and some other defaulta like latency. |
Ah, I didn't know that, but it makes sense and I think you're right.
Thanks for the bug report and good luck with your project. :)
Btw should you decide to add these methods, call them Set*** as is done in
the stdlib. Dtx is now UseDTX but that's not a great name.
Ciao
…On Sat, 24 Dec 2016 at 23:20, Tim ***@***.***> wrote:
Fair enough. Btw the API does provide a separate "application"
(VoIP/music) and "signal type" (voice/audio). I don't know if they are the
same. I guess the former sets the latter and some other defaulta like
latency.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIafOv0SpHt9s5IqiaJAVDzDugis8MPks5rLailgaJpZM4LVNWa>
.
|
Implemented with Pull Request #10 |
There doesn't seem to be any way to set the bitrate, the complexity, the signal type (music/voice/auto), enable/disable VBR and so on.
The text was updated successfully, but these errors were encountered: