Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encoder bitrate #6

Closed
Timmmm opened this issue Dec 24, 2016 · 5 comments
Closed

Set encoder bitrate #6

Timmmm opened this issue Dec 24, 2016 · 5 comments

Comments

@Timmmm
Copy link

Timmmm commented Dec 24, 2016

There doesn't seem to be any way to set the bitrate, the complexity, the signal type (music/voice/auto), enable/disable VBR and so on.

@hraban
Copy link
Owner

hraban commented Dec 24, 2016

signal type is called "application" in opus speak, it's an argument to the encoder constructors / initializers. The bitrate &c are encoder flags, currently only DTX is exposed. There's a bunch of them and I'll accept PRs for them (don't forget tests). I don't need them so I'm not going to implement this, but feel free to add whatever you need. See DTX for an example.

Cheers!

@hraban hraban changed the title Encoder settings missing Set encoder bitrate Dec 24, 2016
@hraban
Copy link
Owner

hraban commented Dec 24, 2016

I'm renaming this issue to be about bitrate specifically. I want a clear fixable target so the ticket doesn't remain open forever. Feel free to open new tickets as you see fit.

@Timmmm
Copy link
Author

Timmmm commented Dec 24, 2016

Fair enough. Btw the API does provide a separate "application" (VoIP/music) and "signal type" (voice/audio). I don't know if they are the same. I guess the former sets the latter and some other defaulta like latency.

@hraban
Copy link
Owner

hraban commented Dec 25, 2016 via email

@dh1tw
Copy link
Contributor

dh1tw commented Dec 30, 2016

Implemented with Pull Request #10

@hraban hraban closed this as completed in dc3e8b1 Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants