Reimplementation of the bytes formatter #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he problem with NAs in the input.
…he problem with NAs in the input.
…refactor_bytes
|
Many thanks! This is a great fix + enhancement. Can you also add yourself
as a contributor in the DESCRIPTION file (pls)? If you wish to remain more
anonymous, just the GH user is fine. - thx
…On Tue, Nov 28, 2017 at 9:10 AM, hcraT ***@***.***> wrote:
I've encountered a problem when ggplot passess in input NAs to the byte
formatter.
This patch fixes this problem. I've reimplemented the function using
logarithms
------------------------------
You can view, comment on, or merge this pull request online at:
#42
Commit Summary
- Reimplementation of the bytes formatter. Adds flexibility and fixes
the problem with NAs in the input.
- Reimplementation of the bytes formatter. Adds flexibility and fixes
the problem with NAs in the input.
- Merge branch 'refactor_bytes' of https://github.com/hcraT/ggalt into
refactor_bytes
File Changes
- *M* R/formatters.r
<https://github.com/hrbrmstr/ggalt/pull/42/files#diff-0> (81)
Patch Links:
- https://github.com/hrbrmstr/ggalt/pull/42.patch
- https://github.com/hrbrmstr/ggalt/pull/42.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#42>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfHtmkRCij_OMjXHYMh08_iAWguDJF2ks5s7BRsgaJpZM4QtS-g>
.
|
|
Done. Thanks! |
|
Thx! There are minor roxygen doc errors causing the build failure that I can quickly nuke. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered a problem when ggplot passess in input NAs to the byte formatter.
This patch fixes this problem. I've reimplemented the function using logarithms