Replace external shell call with read-upto #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elvish now has a read-upto function, which eliminates the need to call an external Bourne shell command to read the gitstatusd response. This is not included in Elvish 0.13 but is available in master.
|
Thanks! I‘m on vacation and won‘t merge this for at least a week more, as I don‘t have a chance to test this. Just one thought: Can we check for the existence of the new function and fall back on the old behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(resubmission of #4 without the incorrect statement that read-upto is included in Elvish 0.13)
Elvish now has a read-upto function, which eliminates the need to call an external Bourne shell command to read the gitstatusd response. This is not included in Elvish 0.13 but is available in master.