Add quiet cmd line option to suppress println to console #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add quiet to Settings object Propagate quite to all places where you have Settings creation Make tests happy
hrj
requested changes
Nov 6, 2016
| @@ -140,7 +140,7 @@ object Processor { | |||
| inputQueue ++= includes.map(id => Input(mkRelativeFileName(id.fileName, inputPath), scope)) | |||
| input.parentScope.addIncludedScope(scope) | |||
| case n: parser.NoSuccess => | |||
| println("Error while parsing %s:\n%s" format (bold(inputPath), n)) | |||
| if (!quiet) println("Error while parsing %s:\n%s" format (bold(inputPath), n)) | |||
There was a problem hiding this comment.
I think error messages shouldn't be suppressed; all else seems fine!
|
Thanks @alexanderzafirov This looks great, except for the one comment about error messages. |
hrj
approved these changes
Nov 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111
Add quiet to Settings object
Propagate quite to all places where you have Settings creation
Make tests happy