Refactor version info #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide each component (base,cli,gui) own version info. - Add buildtime to BuildInfo object, so it can be used, if so wished. - Move initial version info injection up to the main app (cli or gui). - Use own case class for passing build/version info around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this PR is about version info refactoring, so that it will be more usable from perspective of package (base) or from application perspective (cli, gui). This also change the version info boolean to case class, which have two benefits:
It is also good to have own version stamp for base-package and app, because with own base package it could be possible to use published base-package to build app (which will have own buildInfo-data).
This also cleaned up and organized imports with modified files.
Next step is cli-argument (
--version) to ask version info from CLI/GUI app.Original commit message: