Update transactions view when reports are updated #134
Conversation
There was a problem hiding this comment.
Thanks for looking at this long-standing issue. I have noted one problem.
I don't know what the best solution is. Perhaps we could store the selection as a filter (date range + account name). When updating, we can then match all transactions against this filter. Seems inefficient, but reliable.
| selectedItem = selectionModel().getSelectedItem | ||
| // show all transactions of the parent of the selected item if the latter has any transactions | ||
| // this will allow for an update of the transaction view when an input file changes | ||
| if (selectedItem.getValue.txns.nonEmpty) selectedItem = selectedItem.getParent |
There was a problem hiding this comment.
When you change to parent, the transaction view includes more transactions than the selected one.
Try this example:
- In "All" tab, select "Assets" and press Enter
- In the register report for "Assets", select "2013 / Jan" / "Assets:Current:TDS" and press Enter.
- Originally this showed transactions only for "Assets:Current:TDS", but now it will show all transactions in "2013 / Jan"
There was a problem hiding this comment.
I'm aware of the problem, and you're right - it's not pretty. But I didn't know how to solve the problem that arose when selecting specific transactions for display - the update didn't work then. It only works for the root and the date range nodes.
So, your solution proposal isn't too bad at all - I'll look into it.
There was a problem hiding this comment.
Cool.. you can use the TransactionFilter trait defined here.
|
Hi @hrj , I've fixed the problems you've mentioned before (although, I didn't use the TransactionFilter at the end) - it seems to work properly now, although the solution has gotten a bit complex. Maybe you'll see a way to simplify it, or to structure it in a better way. Just let me know if you think any more changes are necessary. |
| } | ||
| def filterSelectedDates(txns: Seq[DetailedPost]): Seq[DetailedPost] = { | ||
| if (selectedTxnDates.isEmpty) txns | ||
| else txns.filter(txn => selectedTxnDates.contains(txn.date)) |
There was a problem hiding this comment.
This will only show newer transactions if they are on the exact same date as one of the previous transactions, right? That is not how I expect it to work. The transactions view is supposed to show all transactions for the selected date range and account name.
I am sorry if the expectation was not clear; the documentation is poor in this project.
|
I think you are on the right track, in general. But the implementation is not matching my expectations fully (probably because they are not well articulated). I will make a stab at implementing this now and set a pull request so that we can discuss my changes. Thanks for inspiring me to work on this issue ✌️ |
|
Oh, ok, I understand. Embarrassingly, I haven't thought about adding new transactions at all! Well, at least I served as an inspiration ;) |
|
(Closed because it was superseded by #137 ) @gerdreiss I have created a new milestone and added few easier issues to it, if you wanna have a look. |
|
Perfect, thanks! I'll take a closer look ;) |
Closes #1