#97 Allow multiple comment entries in single line notation

[gerdreiss]

Hi @hrj , that should be it. Please, let me know if there is anything I could do better, or should do differently.

[coveralls]

Coverage remained the same at 69.324% when pulling 42ed45d on gerdreiss:i97-multiple-comments into f01de5c on hrj:master.

[hrj]

Hi @gerdreiss. Thanks for looking into it.

I had imagined the extra comments following the post comment would become transaction comments, not post comments. I should have clarified that in the issue.

What you have done is fine too, from the code perspective, but it changes the export format and behaviour of subsequent tools that consume the exports. For example, I have a reporting tool which consumes the XML exported from abandon. There might be others too who are using abandon this way. These would require a rewrite if the format changes.

It would be ideal if we could move these extra comments to transaction level.

Again, sorry, I should have expressed this in the issue!

[gerdreiss]

HI @hrj , no problem at all, I'll gladly move the comments to transaction level :)

[coveralls]

Coverage remained the same at 69.324% when pulling b40db12 on gerdreiss:i97-multiple-comments into f01de5c on hrj:master.

[gerdreiss]

Hi @hrj , I've moved the extra post comments to transaction level (hopefully now like you imagined ;-)), but the commit history got a little ugly. I'd like to make a new pull request with one pretty commit (from a new branch). What do you think?

[hrj]

@gerdreiss Sure, you can create a new Pull request.

Or if you are familiar with git rebasing, you can rebase and push again to this branch. (Not recommended if you are new to git)

[coveralls]

Coverage remained the same at 69.324% when pulling 80a84f9 on gerdreiss:i97-multiple-comments into f01de5c on hrj:master.

[gerdreiss]

@hrj Rebase and push was a good idea - now there is just one small commit :)

[hrj]

@gerdreiss Can you change it so that the new syntax only applies to single-line-notation. For multi-line notation, we will maintain status quo for now.

Sorry for chickening out :)

[gerdreiss]

@hrj , sorry for being a bit dense ;-) but I'm not quite sure I understand the change you're requesting...

[hrj]

@gerdreiss

There are two syntaxes for transactions. The older and fuller syntax:

date
  ; txn comment
  account     amount    ; post comment
  account     amount    ; post comment

And the newer, shorter, single line syntax:

. date   account    amount       ; post comment

If I understand right, this PR changes how post comments are parsed, for both syntaxes. However, I would like to make this change only for the shorter, single-line syntax.

The reason is that the older syntax has been around for years and I don't want to break it. The newer syntax we can afford to break a little, especially since the newer syntax has no way to enter a txn level comment.

[gerdreiss]

@hrj I hope I understood the required changes correctly. see my last commit.

[gerdreiss]

@hrj Something went wrong with the build on travis - some dependencies could not be resolved. I'll take that as an excuse to create a new, clean PR :)

Edit: oh, there are issues due to S3 outage in AWS...

[gerdreiss]

@hrj So I've created a new PR with changes for the compact transaction syntax only and a clean commit history. I think we can close this one, if you agree

[hrj]

@gerdreiss Great; will review the other PR and close this one. Thanks!