warning for unused symbols and stdout/stderr output validation

[gerdreiss]

Additional PR for #104 for stdout/stderr output validation

[coveralls]

Coverage decreased (-0.05%) to 69.304% when pulling 039c289 on gerdreiss:i104-symbol-not-used-stdout-test into a260f9a on hrj:master.

[hrj]

Easy but important change required.

[hrj]

You have to make a recursive check for includedScopes as well. Test-case:

{
def y = 10
}

Note the braces which introduces a new scope.

[gerdreiss]

Correct me if I'm wrong, but I think the method definitions in class Scope retrieves the parent and recursively the definitions from the included scopes in private def allLocalDefinitions:

private val localDefinitions = Helper.filterByType[Definition](entries)
private def allLocalDefinitions: Seq[Definition] = localDefinitions ++ includedScopes.flatMap(_.allLocalDefinitions)

  def definitions:Seq[Definition] = {
    val parentDefinitions = parentOpt.map(_.definitions).getOrElse(Nil)
    val allLocalDefs = allLocalDefinitions
    val allLocalNames = allLocalDefs.map(_.name)
    parentDefinitions.filter(d => !allLocalNames.contains(d.name)) ++ allLocalDefs
  }

[hrj]

Hmm.. you seem to be right. The test case fails though (no warning).

[gerdreiss]

That's curious... I'll check it tonight

[gerdreiss]

OK, the problem is that those nested scopes we're looking for are not within the includedScopes, but childScopes. The method checkUnusedSymbols() must be called on the childScopes, too. I'm going to push my change in a moment.

[coveralls]

Coverage increased (+0.04%) to 69.39% when pulling 98724fc on gerdreiss:i104-symbol-not-used-stdout-test into a260f9a on hrj:master.