Transaction validation: date range #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val format = DateTimeFormatter.ISO_LOCAL_DATE | ||
|
|
||
| val from = Try(LocalDate.parse(config.getString("from"), format)).map(Some(_)).getOrElse(None) | ||
| val to = Try(LocalDate.parse(config.getString("to"), format)).map(Some(_)).getOrElse(None) |
There was a problem hiding this comment.
For parsing the constraint dates, you could use the same date-parser as used in the .ledger parser. So the date format will match the one in the .ledger.
|
Looks great, thanks! Apart from the review comments, one more thing remains: we need to add a "suppress error" directive, for posting opening balances. |
Entea
force-pushed
the
transaction_validation_date_range
branch
from
ca03b71
to
1e87401
Compare
Entea
force-pushed
the
transaction_validation_date_range
branch
from
1e87401
to
f5d47ea
Compare
| val to = dateTo.getOrElse(LocalDate.MAX) | ||
| val date = LocalDate.of(post.date.year, post.date.month, post.date.day) | ||
| val from = dateFrom.getOrElse(Date.MIN) | ||
| val to = dateTo.getOrElse(Date.MAX) |
There was a problem hiding this comment.
While MIN and MAX works in most cases, it is hackish. It would be better to use something like this (pseudo code):
dateFrom.map(_ compare post.date).getOrElse(true)
… 3.0.0 is incompatible with scalamock yet - paulbutcher/ScalaMock#147
Entea
force-pushed
the
transaction_validation_date_range
branch
from
d741b02
to
8273dff
Compare
|
@hrj Removed the |
|
💯 for taking care of everything :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #85