Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play next not working (macOS, Homebrew, 0.9.2) #667

Closed
hellquist opened this issue Dec 6, 2021 · 11 comments
Closed

Play next not working (macOS, Homebrew, 0.9.2) #667

hellquist opened this issue Dec 6, 2021 · 11 comments
Labels
bug Something isn't working

Comments

@hellquist
Copy link

Describe the bug
"Play next" no longer works. No matter if I press ">" or type in ":next", it doesn't work.
If I do ">" it will restart the currently playing song. If I type in ":next" it will stop altogether.

To Reproduce
Steps to reproduce the behavior:

  1. Play song
  2. Click on ">" or type ":next"
  3. See error

Expected behavior
I expect it to play another song, either from the playlist order, or a random song if I have random enabled.
It worked fine on 0.9.0.

System (please complete the following information):

  • OS: macOS 11.6.1 (Big Sur)
  • Terminal: iTerm2
  • Version: 0.9.2
  • Installed from: Homebrew
@hellquist hellquist added the bug Something isn't working label Dec 6, 2021
@hellquist
Copy link
Author

Actually, having tested some more, it doesn't move to the next song at all, even when it reaches the end of the current song. It just starts it again. To change song I literally have to select a new song and press enter. Anything else will keep on playing the song it just played. Like if I had "repeat (1)" enabled (though I don't and I never use that setting).

@hellquist
Copy link
Author

Right. My bad. After second reboot of my machine it is now working again. Sorry for raising the alarm too early.

@hellquist
Copy link
Author

Sorry, but it comes back. It has been working fine for most of today, but now it is doing that exact thing again. I can't get past the song I have selected and pressed play on, it just keeps repeating just like if I had "repeat(1)" on, and I can't make it play "next" via ":next" or ">". Something isn't working as it used to.

@hellquist hellquist reopened this Dec 6, 2021
@pekkarinen
Copy link

pekkarinen commented Dec 7, 2021

I had the same problem on Arch Linux with ncspot-bin AUR package, .config/ncspot/userstate.toml had a queue from September. Moved userstate.toml and play next seems to work now as expected.

EDIT: the issue appeared again, Discover Weekly -playlist was not playing nicely, opened an album which worked as expected, after that the playlist worked as well, so maybe I was barking up the wrong tree here.

@hrkfdn
Copy link
Owner

hrkfdn commented Dec 7, 2021

Hmm, I'm trying to reproduce this but I can't :| Anything suspicious in the logs?

@hellquist
Copy link
Author

EDIT: the issue appeared again, Discover Weekly -playlist was not playing nicely, opened an album which worked as expected, after that the playlist worked as well, so maybe I was barking up the wrong tree here.

That made me test the same thing. So I started ncspot. Loaded a playlist that I often play, where I have random and repeat on. "Next" didn't work (as described above). I then loaded a straight "regular" album. It all worked as normal (i.e "next" works in both ways I expect it to). I then reloaded the playlist that hadn't worked. It now works again, and doing "next" picks a random tune and plays it correctly. Very strange.

As with all bugs, consistency is obviously preferred as I then would be able to flawlessly replicate (and report) it (also a lot easier for someone to fix of course), but right now I am not sure what happens, when or why. I shall have to keep my eye on this.

@pekkarinen
Copy link

Selecting a track to play from a playlist via CR queues only that track as opposed to the whole playlist, as happens with albums, or your saved tracks 🤔

@hrkfdn
Copy link
Owner

hrkfdn commented Dec 8, 2021

Ahh, I think that's it. With 0.9.1 I changed the playlist model to also contain podcast episodes, which breaks some queuing logic. Working on a fix.

Unless you actually have more tracks in the queue and it's not playing them? Then it's a different bug.

hrkfdn added a commit that referenced this issue Dec 8, 2021
With the migration to rspotify 0.11.x playlists were changed to be a list of `Playable`
instead of `Track` items, so that playlists can contain podcast episodes.
This needs to be considered when collecting all tracks for playback in `ListView`.

Should help with #667
@hrkfdn
Copy link
Owner

hrkfdn commented Dec 8, 2021

Okay, I have pushed a small fix to main. Please let me know if it helps.

@pekkarinen
Copy link

Okay, I have pushed a small fix to main. Please let me know if it helps.

Quick build & test says it seems to work as expected for playlists now.

@hrkfdn
Copy link
Owner

hrkfdn commented Dec 9, 2021

I'll close it then, let me know if it isn't fixed for you, @hellquist

@hrkfdn hrkfdn closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants