Add `track_format` config option #800

Bettehem · 2022-05-01T00:05:49Z

Hello again!
I added a new config option: tracklist_formatting.
This solves #730 and #558

…mes should be shown before or after the track name.

hrkfdn · 2022-05-09T21:45:09Z

Thanks for the PR, appreciate it. I think a more flexible/customizable approach would be the one described here: #558

It would allow custom formats for tracks (and maybe albums and other types) so users can decide for themselves, but is probably a little bit more complex.

hrkfdn · 2022-05-09T21:45:09Z

Thanks for the PR, appreciate it. I think a more flexible/customizable approach would be the one described here: #558

It would allow custom formats for tracks (and maybe albums and other types) so users can decide for themselves, but is probably a little bit more complex.

Bettehem · 2022-05-09T23:41:17Z

Oh yeah, that sounds like a good idea! I could try changing it to work like that🤔

…h columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option.

Bettehem · 2022-05-10T08:19:44Z

Hello, I have made some some modifications now. I added an active_fields config option which lets you configure what should be shown and in which column. This also removes the need for a separate album_column option. I also added some examples to the README. This should now solve both #730 and #558

hrkfdn

Thanks for reiterating and tackling this. I have a suggestion in the comment below, it would also apply to the other columns. What do you think?

hrkfdn · 2022-05-10T19:39:19Z

src/model/track.rs

+        fields.append(
+            &mut active_fields
+                .left
+                .unwrap_or(vec![ActiveField::Artists, ActiveField::Title])
+                .clone(),
+        );
+        fields.append(
+            &mut active_fields
+                .center
+                .unwrap_or(vec![ActiveField::Album])
+                .clone(),
+        );
+        if fields.contains(&ActiveField::Title) && !fields.contains(&ActiveField::Artists) {
+            write!(f, "{}", self.title)
+        } else if fields.contains(&ActiveField::Artists) && !fields.contains(&ActiveField::Title) {
+            write!(f, "{}", self.artists.join(", "))
+        } else if !fields.contains(&ActiveField::Default)
+            && !fields.contains(&ActiveField::Title)
+            && !fields.contains(&ActiveField::Artists)
+        {
+            write!(f, "")
+        } else {
+            let mut title_index = 1;
+            let mut artists_index = 0;
+            for (i, field) in fields.iter().enumerate() {
+                match field {
+                    config::ActiveField::Title => title_index = i,
+                    config::ActiveField::Artists => artists_index = i,
+                    _ => {}
+                }
+            }
+            if title_index < artists_index {
+                write!(f, "{} - {}", self.title, self.artists.join(", "))
+            } else {
+                write!(f, "{} - {}", self.artists.join(", "), self.title)
+            }


There is a lot of logic here to generate the output string for the columns. I'm wondering if there is a more dynamic approach, i.e. the user can provide something like format_left = "%artists - %title" which is then replaced.

Ok, I like the idea. It would probably make the logic simpler. I'll see what I can do!

# Conflicts: # README.md # src/config.rs

Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs.

� Conflicts: � README.md

Bettehem · 2022-05-25T02:00:22Z

Hi, Sorry for taking so long, I have been busy with other stuff, but I have now made a more flexible system for customizing the formatting. What do you think?

…mes should be shown before or after the track name.

…h columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option.

Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs.

Instead of the lazy static mutex

hrkfdn · 2022-05-27T22:18:55Z

Thanks, looks pretty good already. I've rebased the latest main and did a small refactoring. I'm wondering if we should support formatting for podcast episodes as well? I think they may stick out if you have a playlist with a mix of tracks and podcasts..

Bettehem · 2022-05-27T22:32:48Z

Oh, true. I didn't know you could mix podcasts and songs in the same playlist 🤦
But yeah the formatting should probably work for podcast episodes too if they can be added to the same list.
Thanks for the feedback again, I'll try to make it work for episodes too!

…e_first # Conflicts: # README.md # src/config.rs # src/model/album.rs # src/model/artist.rs # src/model/episode.rs # src/model/playable.rs # src/model/playlist.rs # src/model/show.rs # src/model/track.rs # src/traits.rs # src/ui/contextmenu.rs # src/ui/listview.rs

…on to handle both Tracks and Episodes

Bettehem · 2022-05-28T01:46:20Z

Hmm, I was just testing, and noticed that the custom formatting already works for Episodes in playlists, because episodes in playlists are being treated as tracks. I made a new commit which moves the custom format function to Playable impl so if in the future playlists differentiate between Episodes and Playlists its easier to implement

hrkfdn · 2022-05-28T11:57:56Z

Hmm, I was just testing, and noticed that the custom formatting already works for Episodes in playlists, because episodes in playlists are being treated as tracks.

Huh, indeed. Sounds like a bug, I've just checked and it looks like either rspotify or the Spotify API returns them all as tracks. I have reported this upstream at rspotify: ramsayleung/rspotify#320

I made a new commit which moves the custom format function to Playable impl so if in the future playlists differentiate between Episodes and Playlists its easier to implement.

That makes sense, thanks.

I think we can merge this now. I was wondering whether we should rename the config variables to track_format as it's a little bit shorter and reflects the affected playable type better. What do you think?

Once the bug is fixed we can also support custom podcast formatting, which may have different fields. Also in the future we could add support custom formatting for other playable types, i.e. albums (album_format).

Also shorten `format_{left|center|right}` to `{left|center|right}`

hrkfdn · 2022-05-28T12:12:53Z

I have changed the naming and merged it. Thanks for your contribution and considering all the annoying comments 😄

* Added track_name_first config option to allow choosing if artists' names should be shown before or after the track name. * Added active_fields config option, which allows configuration of which columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option. * Fixed README * Made custom tracklist formatting more flexible. Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs. * Added track_name_first config option to allow choosing if artists' names should be shown before or after the track name. * Added active_fields config option, which allows configuration of which columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option. * Fixed README * Made custom tracklist formatting more flexible. Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs. * Fetch formatting config from library config Instead of the lazy static mutex * Moved custom format function to Playable impl as it's a better location to handle both Tracks and Episodes * Rename from `tracklist_formatting` to `track_format` Also shorten `format_{left|center|right}` to `{left|center|right}` Co-authored-by: Henrik Friedrichsen <henrik@affekt.org>

Bettehem · 2022-05-28T22:26:23Z

I have changed the naming and merged it. Thanks for your contribution and considering all the annoying comments 😄

Nice, and thank you for taking the time to give feedback and suggestions, I'm still a Rust noob so it has been very helpful!

Added track_name_first config option to allow choosing if artists' na…

6914e05

…mes should be shown before or after the track name.

Bettehem added 2 commits May 10, 2022 11:08

Added active_fields config option, which allows configuration of whic…

9280e6b

…h columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option.

Fixed README

b976275

hrkfdn reviewed May 10, 2022

View reviewed changes

Bettehem added 3 commits May 13, 2022 07:42

Merge remote-tracking branch 'upstream/main' into track_name_first

5e06c82

# Conflicts: # README.md # src/config.rs

Made custom tracklist formatting more flexible.

fa57b2b

Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs.

Merge branch 'main' of github.com:hrkfdn/ncspot into track_name_first

7e666e5

� Conflicts: � README.md

Bettehem changed the title ~~Added track_name_first config option~~ Added tracklist_formatting config option May 27, 2022

Bettehem and others added 5 commits May 27, 2022 23:29

Added track_name_first config option to allow choosing if artists' na…

9e3efc3

…mes should be shown before or after the track name.

Added active_fields config option, which allows configuration of whic…

37fefcf

…h columns are visible in Queue/Library view. This also removes the need for a separate track_name_first and album_column option.

Fixed README

288f715

Made custom tracklist formatting more flexible.

e649c57

Updated readme with new instructions. Reformatted impl member order to match the definitions in traits.rs.

Fetch formatting config from library config

b82da01

Instead of the lazy static mutex

Bettehem added 2 commits May 28, 2022 02:01

Moved custom format function to Playable impl as it's a better locati…

c995c81

…on to handle both Tracks and Episodes

Rename from tracklist_formatting to track_format

88b4fe1

Also shorten `format_{left|center|right}` to `{left|center|right}`

hrkfdn changed the title ~~Added tracklist_formatting config option~~ Add track_format config option May 28, 2022

hrkfdn merged commit 4ea3d4a into hrkfdn:main May 28, 2022

This was referenced May 28, 2022

Configuration option for changing the name order of a song #730

Closed

ListView customization #558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `track_format` config option #800

Add `track_format` config option #800

Bettehem commented May 1, 2022 •

edited

Loading

hrkfdn commented May 9, 2022

hrkfdn commented May 9, 2022

Bettehem commented May 9, 2022

Bettehem commented May 10, 2022

hrkfdn left a comment

hrkfdn May 10, 2022

Bettehem May 10, 2022

Bettehem commented May 25, 2022

hrkfdn commented May 27, 2022

Bettehem commented May 27, 2022

Bettehem commented May 28, 2022

hrkfdn commented May 28, 2022 •

edited

Loading

hrkfdn commented May 28, 2022

Bettehem commented May 28, 2022

Add track_format config option #800

Add track_format config option #800

Conversation

Bettehem commented May 1, 2022 • edited Loading

hrkfdn commented May 9, 2022

hrkfdn commented May 9, 2022

Bettehem commented May 9, 2022

Bettehem commented May 10, 2022

hrkfdn left a comment

Choose a reason for hiding this comment

hrkfdn May 10, 2022

Choose a reason for hiding this comment

Bettehem May 10, 2022

Choose a reason for hiding this comment

Bettehem commented May 25, 2022

hrkfdn commented May 27, 2022

Bettehem commented May 27, 2022

Bettehem commented May 28, 2022

hrkfdn commented May 28, 2022 • edited Loading

hrkfdn commented May 28, 2022

Bettehem commented May 28, 2022

Add `track_format` config option #800

Add `track_format` config option #800

Bettehem commented May 1, 2022 •

edited

Loading

hrkfdn commented May 28, 2022 •

edited

Loading