fix(async): properly trigger callbacks when canceling and fix delays in throttle.sync

[folke]

Fixes #1610 #1608 #1610

[folke]

This is the real fix for the delay some users experienced.

Reason is that previsouly the code was not async, so filter would not be running in most cases.
With async, we are hitting the wait in cmp.sync.

Default interval is 200ms for vim.wait which was causing the delays.

[zaqxsw-dev]

thank you, i will check it now

[zaqxsw-dev]

@folke delay is greatly reduced, but not completely gone

[folke]

@hrsh7th instead of 10, it could be set to an even lower value, but I personally don't see the delays anymore in the repro.

[mgnsk]

It's still pretty bad, I tried this:

cmp.visible = cmp.sync(function()
  return cmp.core.view:visible() or vim.fn.pumvisible() == 1
end)

to

cmp.visible = function()
  return cmp.core.view:visible() or vim.fn.pumvisible() == 1
end

and the delay is gone. I have no idea about the architecture of nvim-cmp and why a visibility check would require so much code.

[folke]

@mgnsk the only repro that was provided to me is here

Those delays are fixed by this PR and multiple people confirmed it.

Are you 100% you're on the latest nvim-cmp version?

If the issue persists, then I really need a repro to check.

[mgnsk]

I'll look into it more closely in the evening. I'm sure I saw this PR title when I did Lazy sync.

[hrsh7th]

Thank you so much!

[eeeXun]

I'm still get laggy after this patch.

:version
NVIM v0.9.1
Build type: Release
LuaJIT 2.1.0-beta3

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

/tmp/mini.lua

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/cmp-min/site]])
local package_root = "/tmp/cmp-min/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
    require("packer").startup({
        {
            "wbthomason/packer.nvim",
            {
                "williamboman/mason.nvim",
                config = function()
                    require("mason").setup({
                        install_root_dir = "/tmp/cmp-min/data",
                    })
                end,
            },
            {
                "WhoIsSethDaniel/mason-tool-installer.nvim",
                config = function()
                    require("mason-tool-installer").setup({
                        ensure_installed = {
                            "typescript-language-server",
                        },
                    })
                end,
            },
            {
                "neovim/nvim-lspconfig",
                config = function()
                    local capabilities = require("cmp_nvim_lsp").default_capabilities()
                    require("lspconfig")["tsserver"].setup({
                        capabilities = capabilities,
                    })
                end,
            },
            {
                "ray-x/lsp_signature.nvim",
                config = function()
                    require("lsp_signature").setup({
                        bind = true,
                        toggle_key = "<C-s>",
                        toggle_key_flip_floatwin_setting = true,
                    })
                end,
            },
            {
                "hrsh7th/nvim-cmp",
                requires = { "hrsh7th/cmp-nvim-lsp" },
                config = function()
                    local cmp = require("cmp")
                    cmp.setup({
                        mapping = {
                            ["<CR>"] = cmp.mapping.confirm({ select = true }),
                        },
                        sources = cmp.config.sources({
                            { name = "nvim_lsp" },
                        }),
                    })
                end,
            },
        },
        config = {
            package_root = package_root,
            compile_path = install_path .. "/plugin/packer_compiled.lua",
            display = { non_interactive = true },
        },
    })
end
if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()

Run with nvim -u /tmp/mini.lua. As run it first time, we should quit nvim after plugins are installed. And open it again nvim -u /tmp/mini.lua to let mason-tool-installer.nvim auto install typescript-language-server. Then edit a js file.

2023-06-10_01-21-12.online-video-cutter.com.mp4

As you can see. This doesn't always happen. But quite frequently for me.

BTW. I've checked that after removing lsp_signature.nvim, the input doesn't get stuck.

[mgnsk]

I'm still get laggy after this patch.

@eeeXun See #1613.

Your video is even more clear because it shows which keys were pressed before the lag happened.

[basilgood]

Same here, it's better but still get laggy: #273