Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target node detection should be improved in s:Snippet.follow #58

Closed
hrsh7th opened this issue Jul 19, 2020 · 1 comment
Closed

Target node detection should be improved in s:Snippet.follow #58

hrsh7th opened this issue Jul 19, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@hrsh7th
Copy link
Owner

hrsh7th commented Jul 19, 2020

https://github.com/hrsh7th/vim-vsnip/blob/master/autoload/vsnip/session/snippet.vim#L92

The code does not care about current_tabstop so sometimes it detects unexpected placeholder node.

But currently, vsnip has no problem maybe because https://github.com/hrsh7th/vim-vsnip/blob/master/autoload/vsnip/session/snippet.vim#L115 will fix this gap.
@hrsh7th hrsh7th added the enhancement New feature or request label Jul 19, 2020
@hrsh7th
Copy link
Owner Author

hrsh7th commented Jul 22, 2020

Fixed in 9d32531

@hrsh7th hrsh7th closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hrsh7th