-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip deadzone option on tilt #12756
Skip deadzone option on tilt #12756
Conversation
UI/TiltAnalogSettingsScreen.cpp
Outdated
@@ -41,6 +41,7 @@ void TiltAnalogSettingsScreen::CreateViews() { | |||
settings->Add(new PopupSliderChoice(&g_Config.iTiltSensitivityX, 0, 100, co->T("Tilt Sensitivity along X axis"), screenManager(),"%")); | |||
settings->Add(new PopupSliderChoice(&g_Config.iTiltSensitivityY, 0, 100, co->T("Tilt Sensitivity along Y axis"), screenManager(),"%")); | |||
settings->Add(new PopupSliderChoiceFloat(&g_Config.fDeadzoneRadius, 0.0, 1.0, co->T("Deadzone Radius"), 0.01f, screenManager(),"/ 1.0")); | |||
settings->Add(new PopupSliderChoiceFloat(&g_Config.fTiltDeadzoneSkip, 0.0, 1.0, co->T("Deadzone Skip"), 0.01f, screenManager(),"/ 1.0")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think the name is the trickiest part of this setting, as usual... I'd almost call this a "deadzone boost" or "tilt base radius". It's hard to explain properly alongside "sensitivity"...
Skip makes it too easy to think it'll do the opposite of what it does.
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "alter deadzone on tilt"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed with "Tilt Base Radius", using "deadzone" seem a source of confusion as if usually do the opposite indeed, need "lifezone" I guess :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble understanding the meaning of "tilt base radius": what is the base here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base as a starting point, as when you move a little you start moving from the base radius (is a square, but still). TBH I'm not even sure if there is any non confusing way to say it.
Closes #10808.