Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysclib_strncmp,sysclib_memmove #13038

Merged
merged 4 commits into from
Jun 21, 2020
Merged

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Jun 21, 2020

Add a memory check in sysclib_strstr
ref:
https://github.com/jpcsp/jpcsp/blob/master/src/jpcsp/HLE/modules/SysclibForKernel.java#L107

Used in "Shin Sangoku Musou 6 special" chinese patched game

@@ -774,6 +795,8 @@ const HLEFunction SysclibForKernel[] =
{0x7661E728, &WrapI_UU<sysclib_sprintf>, "sprintf", 'i', "xx", HLE_KERNEL_SYSCALL },
{0x10F3BB61, &WrapU_UII<sysclib_memset>, "memset", 'x', "xii", HLE_KERNEL_SYSCALL },
{0x0D188658, &WrapI_UU<sysclib_strstr>, "strstr", 'i', "xx", HLE_KERNEL_SYSCALL },
{0x7AB35214, &WrapI_UUU<sysclib_strncmp>, "strncmp", 'i', "xxx", HLE_KERNEL_SYSCALL },
{0xA48D2592, &WrapI_UUU<sysclib_memmove>, "memmove", 'i', "xxx", HLE_KERNEL_SYSCALL },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memmove should be U_UUU and returns 'x'.

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Jun 21, 2020

@unknownbrackets done

@hrydgard hrydgard merged commit 282dfb1 into hrydgard:master Jun 21, 2020
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Jun 22, 2020
@sum2012 sum2012 deleted the sysclib_minor branch June 23, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants