Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows][Vulkan/D3D11][Graphic issue] GOD EATER BURST (NPJH50352) #13950

Open
nassau-tk opened this issue Jan 20, 2021 · 9 comments
Open

[Windows][Vulkan/D3D11][Graphic issue] GOD EATER BURST (NPJH50352) #13950

nassau-tk opened this issue Jan 20, 2021 · 9 comments
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Milestone

Comments

@nassau-tk
Copy link
Contributor

What happens?

At some talking scene the graphic will not appear correctly.
It's will happen Vulkan&D3D11.
Like below.
image

If drawing correctly is below.
image

This issue is occurs by decided timing.
Glitch=>Correctly=>Glitch=>Correctly...in the 1 talking scene.

Please see attached GEdump files.

"This GEdump is scene of the issue."
NPJH50352_NG_DUMP.zip

"This GEdump is same scene of correct drawing."
NPJH50352_Good_DUMP.zip

OpenGL is not happen the any issue.

D3D9 is not happen the same issue but some graphic is over light.
(Only Face?)

image

What should happen?

What hardware, operating system, and PPSSPP version? On desktop and mobile phone, GPU matters for graphical issues.

Please test newest version in https://buildbot.orphis.net/ppsspp/

PPSSPP Ver.:1.10.3-1608
OS:Windows10(64-bit)Japanese
CPU:Ryzen7 3800X(8-core)
GPU:RADEON RX5700XT
Resolution:2560×1440
RAM:32GB

@nassau-tk
Copy link
Contributor Author

For reference movie.

GodEaterBurast_Issue.mp4

@sum2012 sum2012 added the GE emulation Backend-independent GPU issues label Feb 6, 2021
@unknownbrackets unknownbrackets added the Depth / Z Issue involves depth drawing parameters. label Feb 21, 2021
@unknownbrackets
Copy link
Collaborator

This is another one that looks related to depth clamp.

That said, an interesting thing to potentially correlate with other issues: this has cull face enabled during the clamping. Maybe that interacts with the clamp/clipping it does in interesting ways.

496/2174 is the first problematic prim. If I flip from CW to CCW, it culls all triangles which are a strip. All depth values in this case are 6 digits and positive.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

The draw here seems to be properly culled based on the rules noted in #12058 - all vertices are outside Z in the same direction.

-[Unknown]

@ghost
Copy link

ghost commented Apr 15, 2022

Can you try adding this game to DisableAccurateDepth compatibility?

Added this game id here's the result using your dump.
Screenshot_2022-04-15-22-21-29-705_org ppsspp ppsspp
Screenshot_2022-04-15-22-21-15-625_org ppsspp ppsspp
Screenshot_2022-04-15-22-23-16-305_org ppsspp ppsspp

@ghost
Copy link

ghost commented Aug 2, 2022

@nassau-tk how about this now?

@nassau-tk
Copy link
Contributor Author

@nassau-tk how about this now?

Yes! These issue was solved!!
Tested on @1.12.3-1411-gb233c2c9a

Vulkan and D3D11 both!!
Thank you!!

@hrydgard hrydgard removed this from the Future-Prio milestone Aug 4, 2022
@unknownbrackets
Copy link
Collaborator

Well, this is only solved for GPUs that have user culling (i.e. not Mali, etc.) or while using software transform. We do have other issues for that already, though. There are actually several issues still open that are solved for many, but not all, GPUs.

-[Unknown]

@hrydgard hrydgard reopened this Aug 6, 2022
@hrydgard
Copy link
Owner

hrydgard commented Aug 6, 2022

Mm, that's right. Let's keep it open.

@hrydgard hrydgard added this to the Future-Prio milestone Aug 6, 2022
@unknownbrackets
Copy link
Collaborator

This should at least now be resolved for devices with user culling OR (working) geometry shader support OR using software transform.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

4 participants