Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the math in cardboard VR mode for wide aspect ratios #14768

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 28, 2021

Avoids issues with very wide aspect ratios. Also very minor cleanups.

Basically, splits the full screen in half properly before centering, instead of chopping both width and height in half and reusing the normal centering, which doesn't work when the screen is wider than 16:9.

Fixes #12982

@hrydgard hrydgard added this to the v1.12.0 milestone Aug 28, 2021
@hrydgard hrydgard changed the title Fix the math in cardboard VR mode Fix the math in cardboard VR mode for wide aspect ratios Aug 28, 2021
@hrydgard hrydgard merged commit 2735b09 into master Aug 28, 2021
@hrydgard hrydgard deleted the cardboard-vr-math-fix branch August 28, 2021 20:49
@Dominiquedb
Copy link

Dominiquedb commented Aug 29, 2021

#12982 (comment)

I have not given up on the feature, never will, I love psp games in vr glasses, and having it working perfectly in ppsspp is the dream.

This update is good, but not quite there yet to get the optimal experience. Same settings in v1.11.3 and v1.11.3-1203-g2735b09eb, vs RetroArch with shutter-to-side-by-side shader.
More tweaking possibilities for the interpupillary distance would still improve upon the experience, the option to actually move the two screens into each other for instance would be great.

As you can see in the screenshots, the centers of the 2 screens remains on the same location, but by changing the eye separation (X- shift) closer together a bigger image is possible, taking full advantage of the phone's display.

Screenshot_20210829-124906405
Screenshot_20210829-125403821-01
Screenshot_20210829-125000109-01
Screenshot_20210829-131822401-01

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 29, 2021

Yeah, okay. Now that the math is right, just extending the range of the sliders should get us closer to that, and maybe additionally blending them into each other... That would take a bit of work though, so as a first step I'm just gonna extend the slider range a bit, shortly.

By the way, if you set the scale to 100%, it should look a bit bigger than in your second screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Cardboard settings on a bigger phone
2 participants