Vulkan: Submit main command buffer before acquiring the swapchain image #16061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially on Android, acquiring the swapchain image can take a little bit of time, and during that time we might as well have the work we've recorded so far submitted to the GPU. I meant to do this in a previous PR but had to pull it out due to issues. With my latest refactorings this was not so hard to get working.
Normally, though, the GPU and CPU won't be tightly synced enough for this to matter, but if my planned idea to minimize latency pans out, this might actually help somewhat.
Also fixes a bug where the screenshot command would be recorded on the wrong commandbuffer, causing it to possibly save an old frame. This was surfaced by submitting early.