Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alpha ignore in xbrz texture shaders. #16125

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

stuken
Copy link
Contributor

@stuken stuken commented Sep 28, 2022

Gpu scaling ignores texture alpha and this is resulting in some upscaled but unfiltered textures. This tends to be mostly hud items but some ui elements can have a mix of filtered and unfiltered elements and it can be quite jarring. Just a small change to roll back an earlier commit that unifies the behaviour accross the two implementations.

Master:
UCES00422_00002
PR:
UCES00422_00001

Master CPU:
UCES00422_00000

Master:
ULES00111_00002
PR:
ULES00111_00001
Master CPU:
ULES00111_00000

@hrydgard
Copy link
Owner

Yeah, looks good, let's have it this way.

@hrydgard hrydgard merged commit 6c7703b into hrydgard:master Sep 28, 2022
@unknownbrackets unknownbrackets added this to the v1.14.0 milestone Sep 28, 2022
@stuken stuken deleted the vk_compute_alpha_fix branch September 28, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants