Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Silent Hill: Origins (depth buffer reassignment, eliminate readback) #16127

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Sep 28, 2022

If a framebuffer starts using a different depth buffer address than before, re-point. This fixes an issue where the wrong depth buffer was being copied from in Silent Hill Origins, causing weird artifacts like this:

image

Ideally we should copy off the depth buffer to another framebuffer that's still pointed at that depth buffer, but in practice this is not very likely to be needed. We'll implement it if we find it is.

Plus, use a compat setting to eliminate readbacks (to improve performance), and reduce some logging.

(This does not fix shadows, that's a separate problem)

See issue #16126

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Sep 28, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Sep 28, 2022
@hrydgard hrydgard changed the title Silent Hill - Origins fixes (depth buffer reassignment, eliminate readback) Fixes for Silent Hill: Origins (depth buffer reassignment, eliminate readback) Sep 28, 2022
@hrydgard hrydgard merged commit 7a4830e into master Sep 28, 2022
@hrydgard hrydgard deleted the silent-hill-fixes branch September 28, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants