GPU: Respect world matrix and reverse flag w/o normals #16265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per tests, Z is still negated even when using the previous normal value.
Even when it's not in the vertex data, we still must multiply by the world matrix. Fixes some lighting issues in Nayuta no Kiseki.
See frame dump in hrydgard#14223, which requires world matrix be applied.
|
Oh, cool find! Happily one with straightforward fixes, we haven't been blessed with those lately :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per some hardware tests, the reverse flag is definitely still applied, and multiplication by the world matrix also happens.
This doesn't explain the Ridge Racer issue, but at least it answers one question.
This is why the jump smoke cloud was colored wrong here:
#14223 (comment)
This corrects that in hardware and software renderers.
-[Unknown]