Fix alpha/stencil replace on Adreno when color masked #16379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When masking via uniform, we don't care about the lower bits of alpha. Games often use 7F / 80 to control writes of FF/00.
Playing it safe for 5xx devices and assuming they are still affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13391, fixes #13886 (at least for the frame dumps.) The workaround in #10421 was activating, but didn't care about replacing alpha with stencil. This makes it blend based on the mask.
While looking for why, I noticed that we set uniformMask to 0x7FFFFFFF when games use 5551 and specify everything but alpha masked, which is a bit wrong. Better to write FF not 80. In theory, could do this for 4444 as well, but I don't think it's as important there.
-[Unknown]