Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blind workaround for Shining Ark circle button problem #16449

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

hrydgard
Copy link
Owner

Seems the game might not handle the case of confirm button being set to cross properly, so force it to circle if this game is running.

Fixes #15663 (hopefully..)

Seems the game might not handle the case of confirm button being set to
cross properly, so force it to circle if this game is running.

Fixes #15663 (hopefully..)
@hrydgard hrydgard added Input/Controller Input and controller issues HLE/Kernel Kernel, memory manager, other HLE issues labels Nov 27, 2022
@hrydgard hrydgard added this to the v1.14.0 milestone Nov 27, 2022
@unknownbrackets
Copy link
Collaborator

Feels like it might be confusing in utility dialogs, although probably makes sense. I guess we don't know for sure this fixes it / is a game bug yet?

-[Unknown]

@hrydgard
Copy link
Owner Author

We don't, no, but there's little else that makes sense as an explanation for the observed behavior in the issue ..

@hrydgard
Copy link
Owner Author

Also I feel it's less confusing to also swap in utility dialog, as then the confirm-as-circle button will be consistent across the game, just not matching what's configured.

@hrydgard hrydgard merged commit 612d218 into master Nov 28, 2022
@hrydgard hrydgard deleted the circle-button-workaround branch November 28, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLE/Kernel Kernel, memory manager, other HLE issues Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shining Ark - circle press ignored
2 participants