GPU: Support framebuf depal from rendered CLUT #16454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already copy to a temp, so just use that copy to normalize out the offset. Should even get RECT2LIN correct, but most cases are 1 pixel high anyway.
Using a temporary always for simplicity.
Fixes color changing after a few moments in Kurohyo.
Open
5 tasks
hrydgard
approved these changes
Nov 28, 2022
|
Works perfectly as expected. In it goes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the transitions into battle in Kurhyo 2 (see #15956.) They're no longer incorrectly red.
For reproduction / posterity:
Here's a frame dump entering battle (incorrectly red before these changes):
#15956_NPJH90274_kurohyo_red_bg.zip
Correct rendering (PSP, software looks the same):
CLUT is rendered at 64/767, to 0x04116200 (256x1, 565.) It's textured from a RAM texture. It's read back as 8888, with
& 0x1f(pass 1), then(>> 5) & 0x1f(pass 2), etc. Basically red/green/blue ramps next to each other. The CLUT address is adjusted each time, which is the first issue:Next, it uses this to depal a framebuffer, so that's the second issue. Finally, it uses this same rendered CLUT for many frames without re-rendering it, and previously we decimated framebuffers if they weren't updated.
-[Unknown]