Eliminate inf values resulting from depth range computation. #18535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's kinda strange for infinite number (which supposed to be close to the largest possible value, eg. due to division by near zero value) to be replaced by 0 :) but as long it works |
|
Yeah the code sample in this case is just busted - Z is entirely broken, it's just not noticable because it's a single, backfaceculled cube. |
|
Oops, should've considered this case. Maybe somehow related to that other game that sets Z range to 0-0 and had problems on some GPUs... -[Unknown] |
|
Well, it's easy to forget that checking for division by zero isn't sufficient to avoid infs... What game was that again? |
|
Ah, I was thinking of "Stand O' Food" but I think it was already fixed by something else. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17981
Who knows, might fix something else. It seems the actual PSP does something similar to this since the Zig sample does work on hardware, and also in the software rasterizer actually.