Partially fix depth issues in multiple games #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks promising, how well tested is it? |
|
Tested around 6-8 games and seems to be no broken. |
| glstate.depthTest.enable(); | ||
| glstate.depthFunc.set(GL_ALWAYS); | ||
| glstate.depthWrite.set(GL_TRUE); | ||
| } |
There was a problem hiding this comment.
This whole block is seemingly equivalent to
glstate.depthTest.enable();
glstate.depthFunc.set(GL_ALWAYS);
glstate.depthWrite.set((depthMask || !gstate.isDepthTestEnabled()) ? GL_TRUE : GL_FALSE);
Which is almost the same as before, except that depthWrite is not set to false if depth testing is disabled, even if the depth mask bit is not set. Interesting. Does disabling depth testing really implicitly enable depth writing?
There was a problem hiding this comment.
It seems odd, but I wouldn't be that surprised actually. The PSP GPU is quite quirky.
hrydgard
added a commit
that referenced
this pull request
Jul 2, 2013
Partially fix depth issues in multiple games
|
Let's try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a better fix for depth issues .It renders depth bit correctly in those games that have issues problem . #2579