Use rewrite #31
Merged
Use rewrite #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antedeguemon
reviewed
Sep 6, 2022
| @@ -20,6 +20,7 @@ | |||
| "mox": {:hex, :mox, "1.0.2", "dc2057289ac478b35760ba74165b4b3f402f68803dd5aecd3bfd19c183815d64", [:mix], [], "hexpm", "f9864921b3aaf763c8741b5b8e6f908f44566f1e427b2630e89e9a73b981fef2"}, | |||
| "nimble_parsec": {:hex, :nimble_parsec, "1.2.3", "244836e6e3f1200c7f30cb56733fd808744eca61fd182f731eac4af635cc6d0b", [:mix], [], "hexpm", "c8d789e39b9131acf7b99291e93dae60ab48ef14a7ee9d58c6964f59efb570b0"}, | |||
| "parse_trans": {:hex, :parse_trans, "3.3.1", "16328ab840cc09919bd10dab29e431da3af9e9e7e7e6f0089dd5a2d2820011d8", [:rebar3], [], "hexpm", "07cd9577885f56362d414e8c4c4e6bdf10d43a8767abb92d24cbe8b24c54888b"}, | |||
| "rewrite": {:hex, :rewrite, "0.1.0", "c8eedbf527ae441c54218ea01c4ec0523ea8be95b0a8e6a875c1a3214df21bbe", [:mix], [{:beam_file, "~> 0.3", [hex: :beam_file, repo: "hexpm", optional: false]}, {:sourceror, "~> 0.11", [hex: :sourceror, repo: "hexpm", optional: false]}], "hexpm", "8b1ca2dce4e872f87e7008ff0acd5abe3a02b039dac487d64948d0a024aeb090"}, | |||
| "sourceror": {:hex, :sourceror, "0.11.2", "549ce48be666421ac60cfb7f59c8752e0d393baa0b14d06271d3f6a8c1b027ab", [:mix], [], "hexpm", "9ab659118896a36be6eec68ff7b0674cba372fc8e210b1e9dc8cf2b55bb70dfb"}, | |||
| "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.6", "cf344f5692c82d2cd7554f5ec8fd961548d4fd09e7d22f5b62482e5aeaebd4b0", [:make, :mix, :rebar3], [], "hexpm", "bdb0d2471f453c88ff3908e7686f86f9be327d065cc1ec16fa4540197ea04680"}, | |||
There was a problem hiding this comment.
We have some unused dependencies that could be unlocked:
mix deps.unlock --unused
Pull Request Test Coverage Report for Build eeb74cc7d2e34d4ebaef9b4a0f6de44f7067415a-PR-31
💛 - Coveralls |
Co-authored-by: Vicente Merlo <vicenteamerlo@gmail.com>
antedeguemon
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
PR is looking awesome @NickNeck! Thanks again for working on a project so interesting to the Elixir community. 💫 🏅
lib/recode/issue.ex
Outdated
| @@ -1,24 +0,0 @@ | |||
| defmodule Recode.Issue do | |||
There was a problem hiding this comment.
Just a minor nit/idea, but what do you think of keeping Issue in Recode instead of moving it to Rewrite?
Seems to me that Rewrite shouldn't be responsible for defining what an issue is - because it is API for rewriting sources. What do you think?
There was a problem hiding this comment.
Good point. We could make the issues in Rewrite.Source to @type issues :: [term()] and let the user of rewrite decide what an issue is.
There was a problem hiding this comment.
@NickNeck seems like a good plan! ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.