Fixes handling of multiple input files #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build ebd0dbcfa740cc3c7029fc21786c0662bd0f927c-PR-38
💛 - Coveralls |
antedeguemon
commented
Oct 26, 2022
| @@ -85,8 +85,7 @@ defmodule Mix.Tasks.Recode do | |||
| defp opts!(opts) do | |||
| case OptionParser.parse!(opts, @opts) do | |||
| {opts, []} -> opts | |||
| {opts, [inputs]} -> Keyword.put(opts, :inputs, inputs) | |||
| {_opts, args} -> Mix.raise("#{inspect(args)} : Unknown") | |||
There was a problem hiding this comment.
Note that there already is a OptionParser.parse! call that checks for unknown arguments - before getting to this line.
This Mix.raise/1 was only called when there were multiple input files.
So this line can be safely removed. 😸
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 🖖
The
mix recodetask fails when multiple files are passed to it:This pull request fix it by updating the task to handle multiple inputs properly.